Use equals() instead of Ref. equality #2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Jun 21, 2021
| PartitionSpec spec = SparkSchemaUtil.specForTable(spark, sourceTableIdentWithDB.unquotedString()); | ||
|
|
||
| if (spec == PartitionSpec.unpartitioned()) { | ||
| if (Objects.equal(spec, PartitionSpec.unpartitioned())) { |
Contributor
Author
There was a problem hiding this comment.
checking for ref. equality is probably fine here, but it takes a reader longer to navigate the code and figure out whether ref equality is really wanted here vs just using equals()
nastra
commented
Jun 21, 2021
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("ReferenceEquality") |
Contributor
Author
There was a problem hiding this comment.
this is for the boolean isRoot = root == rowType check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for SparkTypeToType
nastra
force-pushed
the
equals-instead-of-ref-equality-2
branch
from
db6c75d to
2c080c9
Compare
nastra
commented
Jun 21, 2021
| */ | ||
| public boolean satisfies(SortField other) { | ||
| if (this == other) { | ||
| if (Objects.equals(this, other)) { |
Contributor
Author
There was a problem hiding this comment.
even though using Ref equlity is correct here, it just takes the reader much longer to verify whether it's the intention or not than just using equals() here
rdblue
reviewed
Jun 21, 2021
nastra
force-pushed
the
equals-instead-of-ref-equality-2
branch
from
2c080c9 to
65074bc
Compare
rdblue
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rdblue looks like I missed a few places in #2714 because Gradle was caching some stuff and therefore didn't recompile & re-run ErrorProne. Turns out one has to delete
~/.gradle/caches/build-cache-1before running./gradlew build -x test -x javadoc -x integrationTestlocally in order to see all ErrorProne warnings, as otherwise you only get the results for the projects that were re-compiled.